Golden Helix patches #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull bamtools master
…ng libs to provide their own BamDevice implementation that get's used with certain source names
… index creation to have a callback so client code can compute coverage alongside index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are completely optional, but I've made a number of patches to enable our utalization as bamtools as a library. I've tried to keep them in their own commits.
The patches consist of a number of changes:
Comiler fixes for various compilers (notably the 'u' literal for char values > 128 and removing the static const std:string member of exception class).
Allowing BamDeviceFactor to conduct my own Bam readers as well as make Http/Ftp reader support optional (if you don't include the .cpp/.h files, they won't be available)
Allowing for callback for each alignment during the index process. This allows us to build coverage data alongside the index in a single pass.
Thanks for continuing to support this great project!