Extension of BamReader BamWriter API #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to use a custom IO device for BamRead and BamWrite
| @@ -45,7 +46,8 @@ class BamWriterPrivate { | |||
| bool IsOpen(void) const; | |||
| bool Open(const std::string& filename, | |||
| const std::string& samHeaderText, | |||
| const BamTools::RefVector& referenceSequences); | |||
| const BamTools::RefVector& referenceSequences, | |||
| IBamIODevice* device = 0); | |||
There was a problem hiding this comment.
You should probably fix the formatting here. Also it looks like you should be using NULL in this repository, not 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of BamReader and BamWriter API.
Since BgzfStream already uses dynamic type device it is natural to extend API to allow new device types.
It may be useful functionality for those who want to write or read BAM files using their own IO stream implementation.
This extension does not support index creation using custom IO device. But, that functionality can be added if needed.