index: add receive hook #1644
Open
index: add receive hook #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
force-pushed
the
mhoffm-add-receiveblob-hook-for-indexer
branch
2 times, most recently
from
6caa695
to
4463073
Compare
|
Windows failures seem genuine, but i dont understand them yet. Edit: ignoring EACCESS kinda fixes the issue, im not sure what happens though, something may have a handle to the file open while somethign else attempts the rename. |
MichaHoffmann
force-pushed
the
mhoffm-add-receiveblob-hook-for-indexer
branch
7 times, most recently
from
edc931b
to
36edc4a
Compare
This removes the need for the `cond` storage and hooks up the index and its backing storage using the blobhub. Also fixed a bug where serverinit installs a wrapper instead of the storage which causes the receive hooks to be fired for the wrapper but not for the storage itself causing us to mix sync and index for it.
MichaHoffmann
force-pushed
the
mhoffm-add-receiveblob-hook-for-indexer
branch
from
36edc4a
to
8c9aafc
Compare
bradfitz
reviewed
Jan 27, 2023
| @@ -28,9 +28,9 @@ import ( | |||
|
|
|||
| const maxRemovesPerRequest = 1000 | |||
|
|
|||
| func CreateRemoveHandler(storage blobserver.Storage) http.Handler { | |||
| func CreateRemoveHandler(storage blobserver.Storage, config *blobserver.Config) http.Handler { | |||
There was a problem hiding this comment.
add docs to these methods? how's this config used? send separately?
bradfitz
reviewed
Jan 27, 2023
| @@ -29,22 +29,17 @@ import ( | |||
| "perkeep.org/pkg/blobserver/protocol" | |||
| ) | |||
|
|
|||
| func CreateStatHandler(storage blobserver.BlobStatter) http.Handler { | |||
| func CreateStatHandler(storage blobserver.BlobStatter, config *blobserver.Config) http.Handler { | |||
bradfitz
reviewed
Jan 27, 2023
| @@ -35,13 +36,13 @@ type BlobHub interface { | |||
| // | |||
| // If any synchronous receive hooks are registered, they're run before | |||
| // NotifyBlobReceived returns and their error is returned. | |||
| NotifyBlobReceived(blob.SizedRef) error | |||
| NotifyBlobReceived(context.Context, blob.SizedRef) error | |||
There was a problem hiding this comment.
send all this context plumbing in its own PR(s)?
bradfitz
reviewed
Jan 27, 2023
Comment on lines
44
to
+45
| // NotifyBlobReceived will only return one of the errors. | ||
| AddReceiveHook(func(blob.SizedRef) error) | ||
| AddReceiveHook(func(context.Context, blob.SizedRef) error) |
There was a problem hiding this comment.
and some docs on how the context is used?
bradfitz
reviewed
Jan 27, 2023
Comment on lines
+36
to
48
| found := false | ||
| for _, errno := range []error{ | ||
| syscall.ERROR_ALREADY_EXISTS, | ||
| syscall.ERROR_ACCESS_DENIED, | ||
| } { | ||
| if errors.Is(linkErr, errno) { | ||
| found = true | ||
| break | ||
| } | ||
| } | ||
| if !found { | ||
| return err | ||
| } |
There was a problem hiding this comment.
send separately with a test? document/justify the access denied on rename thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for the
cond+replicastorage configuration and hooks up the index and its backing storage using the blobhub. Also fixed a bug where serverinit installs a wrapper instead of the storage which causes the receive hooks to be fired for the wrapper but not for the storage itself causing us to mix sync and index for it.