app: add initial webdav support #1633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail because i used go1.17 api in places. Fixing in a bit. |
MichaHoffmann
force-pushed
the
mhoffm-add-webdav-app
branch
4 times, most recently
from
1c47f41
to
e939d89
Compare
bradfitz
reviewed
Dec 30, 2022
bradfitz
reviewed
Dec 30, 2022
bradfitz
reviewed
Dec 30, 2022
MichaHoffmann
force-pushed
the
mhoffm-add-webdav-app
branch
from
e939d89
to
9593e52
Compare
MichaHoffmann
force-pushed
the
mhoffm-add-webdav-app
branch
4 times, most recently
from
e775408
to
9f4d499
Compare
Some adaptations had to be made to make perkeepd in `world` be able to start the webdav app. * blobstorage handler is expected to be named `bs-recv` for serverinit/devmode.go * server url needs to be known for the app so that it can fetch its config To facilitate the second point the start up logic in world.go was adapted to try starting on a random port, the resulting flakiness should be acceptable. Obsolete code after this was cleaned up.
MichaHoffmann
force-pushed
the
mhoffm-add-webdav-app
branch
from
9f4d499
to
0ed3196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds WebDAV support for perkeep as an app.
Its read only, but thats something i intend to fix.
I tested this with
cadaverlocally for now.@tgulacsi you suggested this in the past, so tagging you here. wdyt?
addresses #38 #1392 #1017