web-ui/importer: use relative links for importers and accounts #1575
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some network configurations it's annoying that the links in the importer web ui point to the configured base URL. If you use VPN like tailcale you might not have the same URL (like home network IP)to access the server. This changes the links in the web UI to relatives URLs. Since this method is only used in the web UI it should be pretty safe.
aviau
reviewed
Mar 12, 2022
| @@ -1163,7 +1163,7 @@ func (ia *importerAcct) AccountObject() *Object { return ia.acct } | |||
| func (ia *importerAcct) RootObject() *Object { return ia.root } | |||
|
|
|||
| func (ia *importerAcct) AccountURL() string { | |||
| return ia.im.URL() + "/" + ia.acct.PermanodeRef().String() | |||
There was a problem hiding this comment.
Could the base url have a prefix here? ( I haven't checked )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some network configurations it's annoying that the links in the importer
web ui point to the configured base URL. If you use VPN like tailcale you
might not have the same URL (like home network IP)to access the server.
This changes the links in the web UI to relatives URLs. Since this method
is only used in the web UI it should be pretty safe.