Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discovery: expose full fingerprint #1375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

discovery: expose full fingerprint #1375

wants to merge 1 commit into from

Conversation

aviau
Copy link
Member

@aviau aviau commented Jan 25, 2021 •
edited 

discovery: expose full fingerprint

- The discovery endpoint now returns the full key fingerprint.

- Adapt all of the code that used the keyID to use the fingerprint
  instead.

- Begin implementing a test suite for the signhandler's HTTP API.

- Adapt the documentation.

@googlebot googlebot added the cla: yes Author has submitted the Google CLA. label Jan 25, 2021
@aviau aviau force-pushed the aviau/server-fingerprint branch 2 times, most recently from d663295 to 16cffce Compare January 25, 2021 02:13
@aviau aviau requested a review from bradfitz January 25, 2021 02:14
@aviau aviau added the needs review PRs that are ready to go, pending approval label Jan 25, 2021
@aviau
Copy link
Member Author

aviau commented Jan 25, 2021

cc @bradfitz for review!

@aviau
discovery: expose full fingerprint
4df5242 
- The discovery endpoint now returns the full key fingerprint.

- Adapt all of the code that used the endpoint's keyID to use the
  fingerprint instead.

- Begin implementing a test suite for the signhandler's HTTP API.

- Adapt the documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradfitz bradfitz Awaiting requested review from bradfitz

Assignees
No one assigned
Labels
cla: yes Author has submitted the Google CLA. needs review PRs that are ready to go, pending approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aviau @googlebot