-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio file info display and "media" predicate #1291
base: master
Are you sure you want to change the base?
Conversation
meant to be used by other content items, like audio
also refactored to use BlobItemGenericContent
make it possible to identify where the audio is coming from
MediaTagsConstraint was expanded to support matching against all tags, and a new "media" predicate was defined to use that
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot signed it |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Is this PR still alive? I would also like to store my audio files on perkeep and find the UI elements and tag searchability a little lacking. Its working with raw queries, but a little cumbersome. |
This PR adds some UI improvements to audio content blobs, and adds a "media" predicate that searches through all media tags.
Related to #202
Some context:
I am hacking on the audio file handling a bit as I want to use perkeep to play music from my collection on my phone, and just wanted to share this early on. The next thing I wanted to do is have a central player element instead of a per-file one, so that I can navigate while it's playing.