Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio file info display and "media" predicate #1291

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mnzaki
Copy link

@mnzaki mnzaki commented Dec 23, 2019

This PR adds some UI improvements to audio content blobs, and adds a "media" predicate that searches through all media tags.

Related to #202

Some context:
I am hacking on the audio file handling a bit as I want to use perkeep to play music from my collection on my phone, and just wanted to share this early on. The next thing I wanted to do is have a central player element instead of a per-file one, so that I can navigate while it's playing.

meant to be used by other content items, like audio
also refactored to use BlobItemGenericContent
make it possible to identify where the audio is coming from
MediaTagsConstraint was expanded to support matching against all tags,
and a new "media" predicate was defined to use that
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Author has not yet submitted the Google CLA. label Dec 23, 2019
@mnzaki
Copy link
Author

mnzaki commented Dec 23, 2019

@googlebot signed it

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Author has submitted the Google CLA. and removed cla: no Author has not yet submitted the Google CLA. labels Dec 23, 2019
@MichaHoffmann
Copy link
Member

Is this PR still alive? I would also like to store my audio files on perkeep and find the UI elements and tag searchability a little lacking. Its working with raw queries, but a little cumbersome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has submitted the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants