Add read transactions for leveldb #1266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures look like they're unrelated to this change. |
|
Rebased. |
tgulacsi
requested changes
Aug 1, 2021
| return nil | ||
| } | ||
|
|
||
| func getCommon(r leveldb.Reader, readOpts *opt.ReadOptions, key string) (string, error) { |
There was a problem hiding this comment.
get, readerGet? "Common" is too common.
| return string(val), nil | ||
| } | ||
|
|
||
| func findCommon(r leveldb.Reader, readOpts *opt.ReadOptions, start, end string) sorted.Iterator { |
There was a problem hiding this comment.
find, readerFind? "Common" is too common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this branch includes the change from:
https://perkeep-review.googlesource.com/c/perkeep/+/19266
Which says it's been merged, but hasn't hit GitHub (@bradfitz mentioned that the auto-sync had been turned off). Once that lands I'll rebase, but for now only the second commit is relevant.