pkg/index: wait for the database to be actually ready when creating kv #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/test/dockertest: publish container port on random host port, because container IP is actually only reachable when natively on linux. And it has to be a random, variable, port, otherwise concurrent tests runs would block each other when trying to bind on same port. => makes the MySQL tests in pkg/index pass on darwin.
|
FWIW, I've run "go test ./..." also on my linux machine and tests were passing. So I have to investigate what exactly goes wrong on Travis. |
Since the tests also pass on my linux machine, tweaking the travis.yml for more verbosity, to see if we can find out what actually goes wrong on Travis CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/test/dockertest: publish container port on random host port, because
container IP is actually only reachable when natively on linux. And it
has to be a random, variable, port, otherwise concurrent tests runs would
block each other when trying to bind on same port.
=> makes the MySQL tests in pkg/index pass on darwin.