fix(searchPlugin): ensure search updates are unique to collection #6363
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Our app is using the `searchPlugin` with two different collections. We were having issues with search results disappearing randomly when we saved certain records. After digging in, we found that the `syncWithSearch` hook is only searching for matching `search` records by `id`, not `relationTo`. This resulted in the `syncWithSearch` hook incorrectly overwriting records in the wrong collection if they share the same ID. This patch resolves the issue. - [x] I have read and understand the [CONTRIBUTING.md](https://github.com/payloadcms/payload/blob/main/CONTRIBUTING.md) document in this repository. ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug fix (non-breaking change which fixes an issue) ## Checklist: - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] Existing test suite passes locally with my changes - [ ] I have made corresponding changes to the documentation
|
I did run the test suite locally but it seems to be failing for other unrelated reasons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our app is using the
searchPluginwith two different collections. We were having issues with search results disappearing randomly when we saved certain records.After digging in, we found that the
syncWithSearchhook is only searching for matchingsearchrecords byid, notrelationTo.This resulted in the
syncWithSearchhook incorrectly overwriting records in the wrong collection if they share the same ID. This patch resolves the issue.Type of change
Checklist: