Ts migration #756
Open
Ts migration #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastelsky
reviewed
Apr 16, 2023
| @@ -92,7 +106,7 @@ function ExportList({ exports, totalSize, isLoading }) { | |||
| size={exportDictionary[letter][0].gzip} | |||
| totalSize={totalSize} | |||
| name={exportDictionary[letter][0].name} | |||
| path={exportDictionary[letter][0].path} | |||
| // path={exportDictionary[letter][0].path} | |||
There was a problem hiding this comment.
Why did we need to comment this out?
There was a problem hiding this comment.
Why did we need to comment this out?
I think the child component does not use path
pastelsky
reviewed
Apr 16, 2023
| }px`, | ||
| }} | ||
| > | ||
| {dep.percentShare.toFixed(1)} | ||
| {(dep.percentShare || 0).toFixed(1)} |
There was a problem hiding this comment.
This looks rather verbose. We should ensure that if percentShare is nullable, the right fallback value is set on the API side.
There was a problem hiding this comment.
So how do you want to handle this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typescript migration for the frontend