Rotwing guidance bank fix #3271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautierhattenberger
requested changes
May 2, 2024
Comment on lines
+46
to
+50
| #ifdef PREFLIGHT_CHECK_BYPASS | ||
| bool preflight_bypass = PREFLIGHT_CHECK_BYPASS; | ||
| #else | ||
| bool preflight_bypass = FALSE; | ||
| #endif |
There was a problem hiding this comment.
For coherence, can it be written like this ?
Suggested change
| #ifdef PREFLIGHT_CHECK_BYPASS | |
| bool preflight_bypass = PREFLIGHT_CHECK_BYPASS; | |
| #else | |
| bool preflight_bypass = FALSE; | |
| #endif | |
| #ifndef PREFLIGHT_CHECK_BYPASS | |
| #define PREFLIGHT_CHECK_BYPASS FALSE | |
| #endif | |
| bool preflight_bypass = PREFLIGHT_CHECK_BYPASS; |
| @@ -118,7 +118,7 @@ struct FloatMat33 Ga_inv; | |||
| struct FloatVect3 control_increment; // [dtheta, dphi, dthrust] | |||
|
|
|||
| float filter_cutoff = GUIDANCE_INDI_FILTER_CUTOFF; | |||
| float guidance_indi_max_bank = GUIDANCE_H_MAX_BANK; | |||
| float guidance_indi_max_bank = DegOfRad(GUIDANCE_H_MAX_BANK); | |||
There was a problem hiding this comment.
I don't see why this should be converted to degrees, to convert it again to radians later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EwoudSmeur, please verify