Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use altitude waypoints for EKF2 #3242

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

EwoudSmeur
Copy link
Member

As #3153 has gone a bit stale, here a quick fix for EKF2 altitude.

EKF2 does not provide real NED coordinates, but vertically the real altitude is put in the PPRZ NED coordinates. That means that currently if you fly long distance, the waypoints become lower. If you use an INS that outputs real NED coordinates, this doesn't happen.

This can be solved by instead of providing the NED coordinates of waypoints, give the altitude, which is already available from the LLA representation.

@EwoudSmeur
Copy link
Member Author

@Dennis-Wijngaarden tested and it works, so good to merge?

@Dennis-Wijngaarden
Copy link
Contributor

@Dennis-Wijngaarden tested and it works, so good to merge?

Yes, tested and it works

Copy link
Member

@gautierhattenberger gautierhattenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to merge this, but are you still working on a solution discussed in #3091 ? Especially regarding both position and reference model.

@fvantienen fvantienen merged commit 3bedf95 into paparazzi:master Mar 25, 2024
1 check passed
@fvantienen fvantienen deleted the EKF_alt_fix branch March 25, 2024 10:20
@EwoudSmeur
Copy link
Member Author

Regarding #3091, I think it depends on the distances we want to be compatible with. This solution with EKF2 is actually quite ok for long distance, as long as you don't cover many degrees latitude or longitude (so flying at the poles would not be ideal).

What I think is worse if that now we're not consistent with the definitions. There is the 'strict' NED (used by most INS) and the curved NED (used by EKF2). Also the implications for attitude functions like stateGetNedToBodyEulers are not entirely clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants