Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time of week in EXTERNAL_POSE message #3225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FlorianSan
Copy link
Contributor

Timestamps are remapped to the time of week to obtain the correct date when using sd2log.

Copy link
Member

@dewagter dewagter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is very nice. However, you now seem to use the current python client time instead of the more exact measurement time stamp of when the measurement was made.

Could you not compute the ```tow`-stamp`` at the start and then add the offset?

@gautierhattenberger
Copy link
Member

I agree that the time stamp should be based on optitrack value with a possible offset based on the real date. This should be an option to have it or not, but if you need to synchronise data recorded by optitrack software with your log, it is easier to have the same time reference. As we probably don't do that so often, I suggest to have the tow offset enabled by default so that SD log time is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants