LOPS-2300 - Create Terminus Wait for Commit command #2585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insecure File Management (1)
More info on how to fix Insecure File Management in PHP. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
stovak
force-pushed
the
LOPS-2300-Create-Terminus-Workflow-waitForCommit-command
branch
from
ea16b8b
to
847f77e
Compare
| * @aliases workflows | ||
| * | ||
| * @option bool $all Return all of the available workflows, not just the most recent 100 | ||
| * @option bool $all Requests are limited to the last 10 workflows run. This option has been deprecated |
There was a problem hiding this comment.
the option has been deprecated? why?
There was a problem hiding this comment.
If I go by the updated description this is a breaking change that should not be taken lightly. We recently got a ticket (BUGS?) for a customer that wasn't happy getting only 100 workflows and wanted them all; now having only 10 will make them (and lots of other customers I guess) very unhappy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new command based on the new workflow Logs API and will move the main workflow functions to the new Workflow API in an effort to allow customers to wait for a specific commit to be deployed.