Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: revert enforcing the deprecation of exposing blocks in core.internals and deprecate with FutureWarning #58715

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

DEPR: revert enforcing the deprecation of exposing blocks in core.internals and deprecate with FutureWarning #58715

wants to merge 4 commits into from
+72 −3

Conversation

natmokval
Copy link
Contributor

xref #58467

@natmokval natmokval mentioned this pull request May 14, 2024
Merged
@natmokval natmokval marked this pull request as ready for review May 15, 2024 12:13
@natmokval
Copy link
Contributor Author

I reverted the removal of Block and ExtensionBlock from core.internals, and replaced DeprecationWarning with FutureWarning. I think CI failures are unrelated to my changes.

@jorisvandenbossche could you please take a look at my changes? Is that what you meant in your comment in #58467?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@natmokval