Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: shift() of boolean series gives drawdown by an order of magnitude with default filling np.NaN comparing with filling by bool like False #58588

Merged

Conversation

SongYeongEng
Copy link
Contributor

@SongYeongEng SongYeongEng commented May 6, 2024

line 11715: For numeric data, np.nan is used. ->For Boolean and numeric NumPy data types, np.nan is used.

line 11715:  For numeric data, ``np.nan`` is used. ->For Boolean and numeric NumPy data types, ``np.nan`` is used.
@mroeschke mroeschke added the Docs label May 6, 2024
@mroeschke mroeschke added this to the 3.0 milestone May 6, 2024
@mroeschke mroeschke merged commit 362609d into pandas-dev:main May 6, 2024
50 checks passed
@mroeschke
Copy link
Member

Thanks @SongYeongEng

@SongYeongEng SongYeongEng deleted the SongYeongEng-doc-DataFrame.shift branch May 6, 2024 17:07
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…e with default filling np.NaN comparing with filling by bool like False (pandas-dev#58588)

Documentation fix in `generic.py`
line 11715:  For numeric data, ``np.nan`` is used. ->For Boolean and numeric NumPy data types, ``np.nan`` is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants