TST: Add test for duplicate by columns in groupby.agg using pd.namedAgg and asIndex=False
#58579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmokk
changed the title
by columns in groupby.agg using pd.namedAgg (#58446)
jasonmokk
changed the title
by columns in groupby.agg using pd.namedAgg (#58446)
jasonmokk
changed the title
pandas/tests/groupby/test_groupby.py
jasonmokk
changed the title
pandas/tests/groupby/test_groupby.py
jasonmokk
changed the title
by columns in groupby.agg using pd.namedAgg (#58446)
mroeschke
reviewed
May 6, 2024
pandas/tests/groupby/test_groupby.py
Outdated
| @@ -2954,3 +2954,38 @@ def test_groupby_dropna_with_nunique_unique(): | |||
| ) | |||
|
|
|||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("as_index_flag", [False]) | |||
There was a problem hiding this comment.
You can just inline as_index=False in the groupby call below
There was a problem hiding this comment.
Got it, I've updated the PR!
jasonmokk
changed the title
by columns in groupby.agg using pd.namedAgg (#58446)by columns in groupby.agg using pd.namedAgg and asIndex=False
mroeschke
approved these changes
May 6, 2024
|
Thanks @jasonmokk |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…amedAgg` and `asIndex=False` (pandas-dev#58579) * implement test for GH pandas-dev#58446 * Reformat GH issue comment * Directly inline as_index=False in groupby call --------- Co-authored-by: Jason Mok <jasonmok@Jasons-MacBook-Air-4.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupby.aggwithas_index=Falseand duplicate columns inbyfails withpd.NamedAgg. #58446This PR adds a unit test to
pandas/tests/groupby/test_groupby.pyto verify the correct functionality ofgroupby.aggwhen passed inpd.NamedAggobjects with duplicate columns in thebyargument, and withasIndex=False. Addresses GH #58446.