BUG: Series.plot(kind="pie") does not respect ylabel argument #58254
Conversation
abeltavares
force-pushed
the
BUG/Series.plot-does-not-respect-ylabel-argument
branch
2 times, most recently
from
8b97776
to
48c3abe
Compare
abeltavares
force-pushed
the
BUG/Series.plot-does-not-respect-ylabel-argument
branch
2 times, most recently
from
b494748
to
99bc4b3
Compare
pandas/plotting/_matplotlib/core.py
Outdated
| @@ -2090,6 +2087,7 @@ def blank_labeler(label, value): | |||
| return label | |||
|
|
|||
| idx = [pprint_thing(v) for v in self.data.index] | |||
| # `label` is intentionally unused but is required for unpacking the tuple | |||
There was a problem hiding this comment.
I don't follow this comment - shouldn't it be used if provided? Do we have a test for pie charts that providing a label actually set it?
There was a problem hiding this comment.
This label refers to the series name, that was being used to ylabel the pie as default, action that i removed now.
But still need to unpack alongside with y.
Since we now are not using that label but still needed to provide to unpack the tuple i added that comment.
Yes, the ylabelparameter defined by the user for the chart is already being tested as implemented on (#34223).
So I think this solves the issue.
There was a problem hiding this comment.
I would just remove the comment - I don't think it adds any value
pandas/plotting/_matplotlib/core.py
Outdated
| @@ -2090,6 +2087,7 @@ def blank_labeler(label, value): | |||
| return label | |||
|
|
|||
| idx = [pprint_thing(v) for v in self.data.index] | |||
| # `label` is intentionally unused but is required for unpacking the tuple | |||
There was a problem hiding this comment.
I would just remove the comment - I don't think it adds any value
abeltavares
force-pushed
the
BUG/Series.plot-does-not-respect-ylabel-argument
branch
from
99bc4b3
to
6b39485
Compare
abeltavares
force-pushed
the
BUG/Series.plot-does-not-respect-ylabel-argument
branch
from
6b39485
to
0dd3524
Compare
|
Thanks @abeltavares |
…-dev#58254) Co-authored-by: Abel Tavares <abel.tavares@ctw.bmwgroup.com>
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.