Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HSTS isn't currently enabled, which can potentially lead to some security issues, probably the most common of these a man-in-the-middle attack, for more info see:
Basically this informs the client connecting that all requests should be HTTPS, but you can read more about it above, or feel free to ask!
Alongside this, X-Content-Type-Options header is added too, this can stop things like improper scripts running, more info here:
These two alongside CSP is holding back a perfect security score at the moment, CSP can be quite a pain though to implement, these are easy.
There should be zero impact to any current features, but some testing cases could include stuff like ensuring there's no hiccups with a locally hosted pokerogue server or similar connectivity cases
EDIT: to do a somewhat quick security audit yourself - https://observatory.mozilla.org/ is a great resource !