Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSTS + XCTO #1136

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

HSTS + XCTO #1136

wants to merge 4 commits into from

Conversation

danieland
Copy link
Contributor

@danieland danieland commented May 19, 2024

HSTS isn't currently enabled, which can potentially lead to some security issues, probably the most common of these a man-in-the-middle attack, for more info see:

Alongside this, X-Content-Type-Options header is added too, this can stop things like improper scripts running, more info here:

These two alongside CSP is holding back a perfect security score at the moment, CSP can be quite a pain though to implement, these are easy.

There should be zero impact to any current features, but some testing cases could include stuff like ensuring there's no hiccups with a locally hosted pokerogue server or similar connectivity cases

EDIT: to do a somewhat quick security audit yourself - https://observatory.mozilla.org/ is a great resource !

@Tempo-anon Tempo-anon added the enhancement New feature or request label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants