Cleanup game-stats-ui-handler (from PR #1095) #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dakurei
changed the title
Closed
Xavion3
previously approved these changes
May 20, 2024
I've tested it myself, of course, but if anyone else wants to try it too, it's certainly helpful 👍 2024-05-20.12-33-55.mp4 |
Dakurei
force-pushed
the
pr-1095
branch
3 times, most recently
from
08cdd9c
to
c81a744
Compare
|
Test (with german locailzation): (see dakurei-forks#1 pleaes merge it into this :D) English:
Works fine as expected |
|
Added a method I took from one of my personal projects and converted into Typescript to display sums of money in combat and in statistics in a more pleasant way (doesn't replace the old method, it's a complement)
|
+ Modification of the interface to manage labels dynamically (without this, the language change was not reflected until the page was completely refreshed)
+ Changes font size in german only (because otherwise it overflows :D)
…ttle more pleasant to read + The other was a little too barbaric in what it truncated, but is still useful in certain cases + Use abbreviations from 10^0 to 10^33
… in combat and the highest sum of money obtained in statistics
Xavion3
approved these changes
May 26, 2024
XGSleepWalker
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup code of PR #1095