Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout from 3 to 4 #2994

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KristjanESPERANTO
Copy link

No description provided.

Comment on lines +229 to +232
regex: /actions\/checkout@v3/gm,
replacement: "actions/checkout@v4",
test: "uses: actions/checkout@v3",
testRes: "uses: actions/checkout@v4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some regexes to upgrade old configs. It should probably be a new section that takes @V3 to replace with @v4, so that the upgrade still works with the config generated at that point in time.

If you would be able to test a really old upgrade, probably upgrading from actions/checkout@v2 directly to actions/checkout@v4 could be correct, but it is needed to test that (ie, if the upgrade changed from one version of megalinter like Megalinter 5 to 6, then we have an upgrade from Megalinter 6 to 7, changing something in between might break the upgrade chain).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed :)
We need to be able to upgrade v2 to v3 then v3 to v4

A ne rule can be added, as they are processed iterativement, the script will update in the same run from v2 to v3 then to v3 to v4

@echoix
Copy link
Collaborator

echoix commented Oct 7, 2023

Did you manage to have the whole docs be regenerated when changing the lines from the templates and descriptor? Or you simply changed them manually everywhere?

@KristjanESPERANTO KristjanESPERANTO temporarily deployed to dev October 7, 2023 17:18 — with GitHub Actions Inactive
@KristjanESPERANTO KristjanESPERANTO temporarily deployed to dev October 7, 2023 17:18 — with GitHub Actions Inactive
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 14, 2023
@KristjanESPERANTO
Copy link
Author

Sorry for the late reply. It was a manual procedure. I realize now that this is not the right approach, but I don't have the capacity to rework the PR at the moment.

@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants