Bash fixes for Mac (10.12) compatibility #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Need double quotes around $0. 2. Need to include jar files in class path. 3. Used MY_DIR instead of PATH_TO_SELF in classpath.
|
Apparently this fix is specific to the case where the owltools script has a path that contains spaces. For example "/Users/Bob/My Scripts/owltools". If the path to owltools does not contain spaces then this fix is not necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to run owltools on the Mac (OS X 10.12). The following changes were required.
Note that I did not test this on any other systems but I added a test to the script see if it's running on a Mac and if so then the following changes are implemented. If not running on a Mac then there should be no change in behavior.