DO NOT MERGE YET: Upgrade to solr6: DO NOT MERGE YET #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DO NOT MERGE YET Still to do, but can be punted: - variable names may still say 'server' even though solrj changed class name from Server to Client - We use HttpSolrClient which is deprecated; change to builder
|
Tagging @nathandunn @kltm |
|
Just resolved a conflict. Some white-space moved around as well. |
|
|
|
@kltm Is there a way to make this command execute quicker? I feel as though its correct. Also, about how long should it be running for? |
|
Simplified command: |
|
#195 (comment) Also, it's good to get design and work-through comments in the ticket rather than a PR. |
I'm not sure where to document this and I don't know if it's overloading this particular task, but there is a change we need to make ubiquitously across go/monarch. We frequently initialize from a large import chain available via http URLs. This is sensitive to network timeouts etc. Two alternate strategies are possible.
|
|
#195 (comment) I think that's probably overloading what we want to do here; I think it might be better in another ticket. |
nathandunn
changed the title
|
Error of new branch (with these changes) vs SOLR3 using the [same script] (https://github.com/nathandunn/owltools/blob/test-fixes/test3.sh) : |
|
And on the client: |
|
Instructions for SOLR7:
|
|
Redid the SOLR3 vs this PR merge and it worked (yeah!) running this (https://github.com/nathandunn/owltools/blob/test-fixes/test3-local.sh) though requires a local copy of the GAF file as the scripts don't like https (maybe something to fix). Going to need to try again SOLR7 next. |
|
From: https://github.com/monarch-initiative/solr-docker-monarch-golr/blob/master/files/run.sh solr6 instructions:
|
|
Still getting: |
|
If we are truly confident that this branch is compatible with both solr3 and solr6, then we can merge it, simplifying things a lot. Perhaps set up a different PR for discussion of solr7 client code, or for dockerizing solr6/7? |
|
Lemme bounce over and test... |
|
...or not. The build fails for me on this branch, but not master with: |
|
Confident with 3. Not confident with 6, though its probably an error on my part. I'm pretty confident that the migration between 6 and 7 shouldn't pose any problem. |
|
It works for me. . . . How is it failing for you?
… On Feb 15, 2018, at 2:18 PM, kltm ***@***.***> wrote:
...or not. The build fails for me on this branch, but not master with: mvn clean install -DskipTests -Dmaven.javadoc.skip=true -Dsource.skip=true in OWLTools-Parent
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#195 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAt2qi9JLsWerD4JkVaJ_ktLdVCeqEMRks5tVK1NgaJpZM4NNLEh>.
|
|
Are you running the top-level About a hundred unfound symbols a la: |
|
That’s what I did originally. I’m wondering if you need to blow out your maven because of the version changes?
That is weird. I have done about 3 clean checkouts as well with different branches and no problems.
… On Feb 15, 2018, at 2:37 PM, kltm ***@***.***> wrote:
Are you running the top-level build.sh?
About a hundred unfound symbols a la:
[ERROR] /home/sjcarbon/local/src/git/owltools/OWLTools-Solr/src/main/java/owltools/solrj/GafSolrDocumentLoader.java:[565,22] cannot find symbol
symbol: class SolrInputDocument
location: class owltools.solrj.GafSolrDocumentLoader
[ERROR] /home/sjcarbon/local/src/git/owltools/OWLTools-Solr/src/main/java/owltools/solrj/GafSolrDocumentLoader.java:[570,17] cannot find symbol
symbol: class SolrInputDocument
location: class owltools.solrj.GafSolrDocumentLoader
[ERROR] /home/sjcarbon/local/src/git/owltools/OWLTools-Solr/src/main/java/owltools/solrj/GafSolrDocumentLoader.java:[570,53] cannot find symbol
symbol: class SolrInputDocument
location: class owltools.solrj.GafSolrDocumentLoader
[ERROR] /home/sjcarbon/local/src/git/owltools/OWLTools-Solr/src/main/java/owltools/solrj/PANTHERSolrDocumentLoader.java:[49,33] cannot find symbol
symbol: class SolrInputDocument
location: class owltools.solrj.PANTHERSolrDocumentLoader
[INFO] 102 errors
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#195 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAt2qvGbVRSXcAZZ2G7T94YVXpg7k6kbks5tVLHCgaJpZM4NNLEh>.
|
|
I think its working, but I need to update the schema.xml file for 6 / 7: if you have one, great, otherwise I'll work through this: |
|
Works using the managed schema: https://raw.githubusercontent.com/berkeleybop/bbop-manager-golr/master/solr/server/solr/amigo/conf/managed-schema |
|
and change the --solr-url from http://localhost:8983/solr/ to http://localhost:8983/solr/golr/ |
|
nathandunn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194
Still to do, but can be punted:
cc @kltm