Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more Israel chains #9443

Merged
merged 10 commits into from
May 24, 2024
Merged

Added more Israel chains #9443

merged 10 commits into from
May 24, 2024

Conversation

Flatroy
Copy link
Contributor

@Flatroy Flatroy commented May 5, 2024

No description provided.

@Flatroy Flatroy changed the title Add more Israel chains Added more Israel chains May 17, 2024
@bhousel
Copy link
Member

bhousel commented May 24, 2024

This seems ok, but:

  • Items without a Wikidata identifier won't get included in any of the editor presets.
  • A few items that seem mistagged, (e.g. Golf & Co. https://www.golfco.co.il/ seems to be more like houseware, not clothes)

But I'm happy to accept it as-is and people can change the categories later if they want to.

@bhousel bhousel merged commit 3c197de into osmlab:main May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flatroy @bhousel