support gap_to_julia(::AbstractVector)
#989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had been claimed already before the change, but it was not tested.
After generalizing the three-argument method of `julia_to_gap`
from `Vector` to `AbstractVector`,
the default method that discards the last two arguments is no longer
applicable to `AbstractRange{<:Integer}`,
hence the special one-argument method does not get called.
For the moment, install a three-argument method for `AbstractRange{<:Integer}`.
(And add tests that check whether we really get a GAP `IsRange` object in the end.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
==========================================
+ Coverage 75.74% 75.75% +0.01%
==========================================
Files 51 51
Lines 4188 4190 +2
==========================================
+ Hits 3172 3174 +2
Misses 1016 1016
|
|
CI-failures with Julia nightly, concerning the way how |
ThomasBreuer
added a commit
to ThomasBreuer/Oscar.jl
that referenced
this pull request
May 13, 2024
add a `GAP.julia_to_gap(::JSON3.Array, ...)` method until the fix from oscar-system/GAP.jl/pull/989 is available
This was changed in JuliaLang/julia#54305 and was first present in |
fingolfin
pushed a commit
to oscar-system/Oscar.jl
that referenced
this pull request
May 14, 2024
…) or `f.map` (for group homomorphisms) (#3681) * use `GapObj` instead of `.values` access for group characters * use `GapObj(f)` not `f.map` for `f::GAPGroupHomomorphism` (and replace more `.X` access by `GapObj`) * replace `GAPTable` for char. tables by `GapObj` * simplify recursive `GapObj` calls * more `GapObj` calls using `recursive = true` * add a `GAP.julia_to_gap(::JSON3.Array, ...)` method until the fix from oscar-system/GAP.jl/pull/989 is available
fingolfin
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had been claimed already before the change that
gap_to_julia(::BitVector)works, but this was not tested.(The problem was uncovered because
gap_to_julia(::JSON3.Array)did not work.)