Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revoke refresh token on request only #766

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vivshankar
Copy link
Contributor

The OAuth 2.0 Token Revocation specification (RFC7009)
indicates that the authorization server can choose to only revoke refresh tokens if the token in the request is a
refresh token in the authorization grant.

This change gives an option to not revoke the refresh token if the token in the request is an access token.

Related Issue or Design Document

N/A

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

N/A

@vivshankar
Copy link
Contributor Author

@aeneasr Do you mind taking a look at this? It's a fairly simple change and has no compatibility impact.

@aeneasr
Copy link
Member

aeneasr commented Feb 7, 2024

Sorry, I lack the time to look into PRs in fosite at the moment. This looks good to me, but it would be even better if there was a small test for this!

Copy link
Contributor

@mitar mitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but yes, tests please.

@vivshankar
Copy link
Contributor Author

@aeneasr @mitar Added tests

@mitar
Copy link
Contributor

mitar commented Feb 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants