Replace abc.ABC with typing.Protocol in BaseStorage
#5449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porink0424
changed the title
abc.ABC with typing.Protocol in BaseStorage
|
This pull request has not seen any recent activity. |
|
This pull request has not seen any recent activity. |
|
We discussed whether we should introduce protocol to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Same motivation as #5425.
Description of the changes
abc.ABCwithtyping.ProtocolinBaseStorage.typing_extensionsdependency when python version is less than 3.8.Note
Similar concerns as in #5425 apply here. Dynamic type checking would be no longer available such as
isinstance(storage, BaseStorage),issubclass(cls, BaseStorage). The migration guide will be needed.