Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add details on security for invokers #942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

keithamus
Copy link
Collaborator

This adds some prose around security considerations for invokers.

Refs #904 and whatwg/html#9625

Copy link
Member

@gregwhitworth gregwhitworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single question added, non-blocking. Great addition to the explainer.

site/src/pages/components/invokers.explainer.mdx Outdated Show resolved Hide resolved
@keithamus keithamus force-pushed the add-details-on-security-for-invokers branch from 94c9338 to e94f52c Compare February 22, 2024 09:59
@keithamus keithamus force-pushed the add-details-on-security-for-invokers branch from e94f52c to 235f859 Compare February 22, 2024 10:01
@keithamus
Copy link
Collaborator Author

I've rebased this and addressed some of the comments, so please take a re-read and let me know if there's any more feedback!

`<input type=file>` for example; dressing the `<label>` to look like a
`<button>` and hiding the `<input>`.

This proposal allows showing the pickers of input elements, for example an
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth explaining that invokers as currently implemented fully enforce the cross-origin blocking and don't including the file or color carveouts that showPicker has?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have the explainer speak to a current implementation or a desired one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desired one. And I think the implementation is the desired one we shouldn't special case file and color for invokers imo

There is also additional concern around the media element invokers being able
to circumvent autoplay policies. Invokers should not be able to cicurmvent
these, and so the play or playpause actions should only be functional in
environments which allow autoplaying of videos.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the correct mitigation. They should just behave the same way as the JS APIs, for example if there's no activation and you play then it plays but muted.

Would need to understand the exact specifics across browsers here.

Co-authored-by: Luke Warlow <luke@warlow.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants