add toggle action to invokers dialog #936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
requested review from
gregwhitworth,
mfreed7 and
dbaron
as code owners
|
I think it should exist for completeness. Unless we make it so invokers ONLY work for modal dialogs? Which could be an option? Also gonna link #920 |
|
Linking #935 discussion |
lukewarlow
requested changes
Nov 16, 2023
Co-authored-by: Luke Warlow <luke@warlow.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When prototyping/implementing the behaviour for invokers on
<dialog>, I noticed thattogglewasn't an action available, onlytoggleModal.For completeness and compatibility with non-modal dialogs, I went ahead and implemented
toggle, which begs the question: should it exist?Rather than raising an issue I thought I'd raise a PR for us to speculate on.
One reason to not add this is whatwg/html#9376 - which asks if we should deprecate
.show()altogether./cc @lukewarlow @mfreed7 @scottaohara