added multilinugal top menu #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgiamoon
reviewed
Apr 7, 2017
| <li><a href="{{site.baseurl}}/{{page.lang}}/about/guiding-principles">Des principes directeurs</a></li> | ||
| <li><a href="{{site.baseurl}}/{{page.lang}}/about/where-its-used">Où il est utilisé</a></li> | ||
| <li><a href="{{site.baseurl}}/{{page.lang}}/about/press">Presse</a></li> | ||
| <li><a href="{{site.baseurl}}/{{page.lang}}/about/license-privacy">Licence & Intimité</a></li> |
There was a problem hiding this comment.
Intimite should be confidentialité
georgiamoon
reviewed
Apr 7, 2017
| <li><a href="https://wiki.commotionwireless.net">Wiki</a></li> | ||
| <li><a href="https://github.com/issues?q=is:issue+user:opentechinstitute+is:open">Suivi du problème</a></li> | ||
| <li><a href="{{site.baseurl}}/{{page.lang}}/developer/hig/introduction">Guide de l'interface humaine</a></li> | ||
| <li><a href="{{site.baseurl}}/{{page.lang}}/jobs">Requests for Proposals</a></li> |
There was a problem hiding this comment.
Should this also be Emplois ?
There was a problem hiding this comment.
We had made this separate menu item 'requests for proposals' in the 'developer' section but it does link to the same place. I'm adding a translation for it now.
|
Put some comments on the french translations. |
|
I am working on the rest of issue #360 so please hold off on merging until that's done. |
|
@jheretic Multilingual menu support should now be complete with my last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic for a top menu in multiple languages and google translate versions of the top menu in Spanish and French