Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Derived Field] Integration tests for derived fields #13721

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

rishabhmaurya
Copy link
Contributor

@rishabhmaurya rishabhmaurya commented May 16, 2024

Description

  • tests derived fields when defined in index mappings
  • tests derived fields when defined in query
  • tests mappings and settings updates for derived fields
  • tests index and search analyzer applicability on derived fields
  • tests query string
  • tests fetch fields and highlight on derived field of type text. Currently highlighter of type unified is supported.
  • tests ignore_malformed, format, source_indexed_field and properties for explicit type definitions.

The diff will reduce once preceding PRs are merged - #13592, #13717 and #13720

Related Issues

Resolves
#13715

#13143

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 2648711: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 17b7d5b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for bd085ed: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for bd085ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for bd085ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b4c4dce: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ Gradle check result for 78bc3a9: SUCCESS

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.72%. Comparing base (b15cb0c) to head (ed2223a).
Report is 389 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13721      +/-   ##
============================================
+ Coverage     71.42%   71.72%   +0.30%     
- Complexity    59978    61744    +1766     
============================================
  Files          4985     5094     +109     
  Lines        282275   289677    +7402     
  Branches      40946    41875     +929     
============================================
+ Hits         201603   207767    +6164     
- Misses        63999    64805     +806     
- Partials      16673    17105     +432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for ebee61d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

* tests derived fields when defined in index mappings
* tests derived fields when defined in query
* tests mappings and settings updates for derived fields
* tests index and search analyzer applicability on derived fields
* tests query string

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
@rishabhmaurya rishabhmaurya added the backport PRs or issues specific to backporting features or enhancments label Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for 793a372: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❕ Gradle check result for 793a372: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 0aa121d:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rishabhmaurya rishabhmaurya mentioned this pull request Jun 10, 2024
6 tasks
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Copy link
Contributor

✅ Gradle check result for bf10ba6: SUCCESS

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Copy link
Member

@mch2 mch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @rishabhmaurya pls tag flakies here if not already done.

@rishabhmaurya
Copy link
Contributor Author

flaky tests encountered in previous failing checks -
#10006
#13503
#13476
#13792
#13473

Copy link
Contributor

❌ Gradle check result for ed2223a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for ed2223a: SUCCESS

@mch2 mch2 added the backport 2.x Backport to 2.x branch label Jun 10, 2024
@mch2 mch2 merged commit c49eca4 into opensearch-project:main Jun 10, 2024
34 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13721-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c49eca4061d3af9af77a3eacd28043200343ba98
# Push it to GitHub
git push --set-upstream origin backport/backport-13721-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13721-to-2.x.

rishabhmaurya added a commit to rishabhmaurya/OpenSearch that referenced this pull request Jun 10, 2024
…ect#13721)

* Integration test for derived fields

* tests derived fields when defined in index mappings
* tests derived fields when defined in query
* tests mappings and settings updates for derived fields
* tests index and search analyzer applicability on derived fields
* tests query string

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* rename source_indexed_field to prefilter_field

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Add entry to CHANGELOG

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

---------

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
(cherry picked from commit c49eca4)
mch2 pushed a commit that referenced this pull request Jun 11, 2024
* Fix the breaking change check due to Derived fields changes in 2.15

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* [Derived Field] Integration tests for derived fields (#13721)

* Integration test for derived fields

* tests derived fields when defined in index mappings
* tests derived fields when defined in query
* tests mappings and settings updates for derived fields
* tests index and search analyzer applicability on derived fields
* tests query string

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* rename source_indexed_field to prefilter_field

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

* Add entry to CHANGELOG

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>

---------

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
(cherry picked from commit c49eca4)

---------

Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants