-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Add segment transfer timeout dynamic setting #13679
[Remote Store] Add segment transfer timeout dynamic setting #13679
Conversation
Signed-off-by: Varun Bansal <bansvaru@amazon.com>
❌ Gradle check result for 8f59a8d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 85416eb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/RemoteStoreSettings.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/shard/RemoteStoreRefreshListenerTests.java
Show resolved
Hide resolved
…rrupted latch.await Signed-off-by: Varun Bansal <bansvaru@amazon.com>
Signed-off-by: Varun Bansal <bansvaru@amazon.com>
a4ac198
to
16eb7d2
Compare
❌ Gradle check result for a4ac198: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 62e73e5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for cbca4ee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Varun Bansal <bansvaru@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13679 +/- ##
============================================
+ Coverage 71.42% 71.58% +0.16%
- Complexity 59978 61255 +1277
============================================
Files 4985 5063 +78
Lines 282275 287917 +5642
Branches 40946 41691 +745
============================================
+ Hits 201603 206108 +4505
- Misses 63999 64770 +771
- Partials 16673 17039 +366 ☔ View full report in Codecov by Sentry. |
server/src/test/java/org/opensearch/index/shard/RemoteStoreRefreshListenerTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
server/src/main/java/org/opensearch/index/shard/SegmentUploadFailedException.java
Show resolved
Hide resolved
Please add changelog entry, fix the gradle build and complete the check-list in PR description. |
Signed-off-by: Varun Bansal <bansvaru@amazon.com>
Thanks @sachinpkale for approving. I've added the necessary details and addressed your comment. |
❕ Gradle check result for 251ecd0: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13679-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b3049fb5ec860f63fdfe33c5b176869b1e4255e6
# Push it to GitHub
git push --set-upstream origin backport/backport-13679-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…ch-project#13679) * [Remote Store] Add segment transfer timeout dynamic setting Signed-off-by: Varun Bansal <bansvaru@amazon.com> (cherry picked from commit b3049fb)
…ch-project#13679) * [Remote Store] Add segment transfer timeout dynamic setting Signed-off-by: Varun Bansal <bansvaru@amazon.com> (cherry picked from commit b3049fb)
Description
Related Issues
Resolves #13783
Check List
API changes companion pull request created.Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.