Show save dialog when exiting via shortcut or menu item #5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As it's possible to open multiple windows, are you sure that your fix doesn't just close the current window instead of quitting the application? |
|
There's definitely some unintended interaction with multiple windows open! I'll see if I can figure out the best solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl-Q on Linux doesn't prompt to save files like the normal window close button, and I managed to lose work several times over it.
Digging into the openscad (and Qt) source code revealed that File -> Quit has the same behaviour, and it most likely happens on OS X too (Cmd-Q).
I'm no C++ developer, but the fix appeared to be relatively simple once I found it.