-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC 2023: Macro to allow building with OpenGL Core #4738
base: master
Are you sure you want to change the base?
Conversation
6fdb8aa
to
ffc0189
Compare
faae63b
to
c3c4a65
Compare
One note: This PR was created by generating bindings where only OpenGL 3.2 core profile entry points are available. However, modern OpenGL is defined by not only entry point but also how these entry points are used. openscad/src/glview/system-gl.cc Line 67 in c3c4a65
There are numerous similar examples in the codebase. Finding them all may be quite some work, and I'm not convinced that partially removing legacy calls is worth merging to master, especially without a more concrete plan for how to proceed. I'll think and tinker with this over the next few months and see if I can come up with a plan. |
@kintel can you let me know if there is a more intuitive source I can look at for listing these additional removed features? My general guide has been the instructions from the wiki but a quick search there doesn't return anything for I'm also curious why the compiler even let this build with Core Profile headers if I missed some legacy calls. |
You weren't missing legacy calls, but legacy argument to calls. The OpenGL 3.2 core profile spec, appendix E.2.2 is a great start: https://registry.khronos.org/OpenGL/specs/gl/glspec32.core.pdf ..but the easiest road to success may be running tests until they pass, but that may require a more bottom-up approach. |
If compiled with
-DDISABLE_FIXEDFUNCTION_GL
, all API calls to legacy OpenGL functions are removed. Otherwise this PR is a no-op. The mxe-64 test is failing because so is the current master branch.