Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map page layout fixes #495

Merged
merged 12 commits into from
Dec 7, 2022
Merged

Map page layout fixes #495

merged 12 commits into from
Dec 7, 2022

Conversation

gsehrlich
Copy link
Collaborator

@gsehrlich gsehrlich commented Oct 14, 2022

Checklist

  • Add description
  • Reference the open issue that the pull request addresses
  • Pass code quality checks
    • spin up docker docker-compose up -d --build
    • enter api container docker-compose exec api /bin/bash
    • run api tests make validate
    • exit container ctrl/command+D or exit
    • enter web container docker-compose exec web /bin/sh
    • run front-end tests npm run test or npx jest
    • lint npm run lint-fix
    • exit container as above
  • Request code review
    • Please allow 36 hours from opening a pull request before merging a pull request- even if it has already received an approving review.
  • Address comments on code and resolve requested changes
  • Merge own code

Description

Issue: #494

Brief description of solution

  • Use Semantic UI more/better
    • Remove redundant nested Containers
    • Switch out plain HTML components for Semantic UI components
    • Eliminate unnecessary CSS
    • Do more of this
  • Square map box
  • Create footer
    • Use Semantic UI React Menu
    • Change App.js styles so that footer is at the bottom of the page even if the content is shorter
    • Add logos
  • Remove grid container's negative margin
  • Move nav items up
  • Logo fixes
  • Font fixes

Copy link
Collaborator

@ayennac ayennac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looked good! I have a question was the move from to

on line 55 of map/menu.js, but I'll slack it to you!

@gsehrlich gsehrlich merged commit 4f45ff2 into develop Dec 7, 2022
@gsehrlich gsehrlich deleted the 494_map-page-layout-fixes branch December 7, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants