-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
331 pin on click #472
331 pin on click #472
Conversation
…with longitude and latitude
@gsehrlich Should we start with this link for the question mark icon destination? https://www.airnow.gov/aqi/aqi-basics/ It's imperfect, because it implies we're measuring more than just PM2.5, but I think it's a decent MVP start. I also wonder if we should change the icon from a question mark to an off-site link icon. Normally I would discourage opening links in a new window, but given the nature of the interaction (that users will likely want to remain in the map experience), I wonder if we should make an exception in this instance. E.g. "external square alternate" from Semantic UI. |
I think it's a decent start as well, certainly better than the EPA
homepage, which is what I have in there right now. My main concern is
actually that users will think the numbers on the map (which are in hidden
units of micrograms per cubic meter) mean the same thing as the numbers in
the chart (which have been converted to AQI). Especially since I haven't
added text anywhere yet to clarify that.
…On Thu, Jun 2, 2022 at 10:52 AM Jess Sand ***@***.***> wrote:
@gsehrlich <https://github.com/gsehrlich> Should we start with this link
for the question mark icon destination?
https://www.airnow.gov/aqi/aqi-basics/
It's imperfect, because it implies we're measuring more than just PM2.5,
but I think it's a decent MVP start.
—
Reply to this email directly, view it on GitHub
<#472 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACT5UIWJ3VPNY7IVKI2T2YLVNDYEBANCNFSM5XDCRMQQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yeah, I hear that. Not sure we should worry about it for MVP but maybe prioritize it as a fast-follow for improvements? |
Actually, I'm just realizing, we have an open criteria item in the comments on this in-progress issue: #464 (comment) |
Good point. Maybe I'll just implement that when I put the new link in and
call it done.
…On Thu, Jun 2, 2022 at 4:54 PM Jess Sand ***@***.***> wrote:
Actually, I'm just realizing, we have an open criteria item in the
comments on this in-progress issue: #464 (comment)
<#464 (comment)>
—
Reply to this email directly, view it on GitHub
<#472 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACT5UIXMSBJ6PO6GFUWC2JLVNFCR3ANCNFSM5XDCRMQQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist
docker-compose up -d --build
docker-compose exec api /bin/bash
make validate
ctrl/command+D
orexit
docker-compose exec web /bin/sh
npm run test
ornpx jest
npm run lint-fix
Description
Issues: #331, #442, and #464
Brief description of solution
Reviewer: It'll be easier to understand my edits by looking at the individual commits. At least for the last batch of commits (today's), I separated them into hunks representing atomic changes.