Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unit in map hover #465

Merged
merged 1 commit into from
May 15, 2022
Merged

Change unit in map hover #465

merged 1 commit into from
May 15, 2022

Conversation

gsehrlich
Copy link
Collaborator

@gsehrlich gsehrlich commented May 4, 2022

Checklist

  • Add description
  • Reference the open issue that the pull request addresses
  • Pass code quality checks
    • spin up docker docker-compose up -d --build
    • enter api container docker-compose exec api /bin/bash
    • run api tests make validate
    • exit container ctrl/command+D or exit
    • enter web container docker-compose exec web /bin/sh
    • run front-end tests npm run test or npx jest
    • lint npm run lint-fix
    • exit container as above
  • Request code review
    • Please allow 36 hours from opening a pull request before merging a pull request- even if it has already received an approving review.
  • Address comments on code and resolve requested changes
  • Merge own code

Description

Issue: #464

Brief description of solution
Delete the units.

@gsehrlich gsehrlich requested a review from exchrotek May 4, 2022 05:18
Copy link
Collaborator

@exchrotek exchrotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

image

@gsehrlich gsehrlich merged commit 42b3961 into develop May 15, 2022
@gsehrlich gsehrlich deleted the 464_change-unit-in-map-hover branch May 15, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants