Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more sanity checks config options #901

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

atomlin-git
Copy link

Feature #611

Made:

  • print warning, if:

    • 'enable_query' disabled, and 'announce' enabled
    • 'max_bots' >= 'max_players'
  • print error, if cant create scriptfiles folder

  • fix negative values variables (player_timeout, minimum_connection_time, messages_limit, message_hole_limit, acks_limit, limits_ban_time, weather, time)

@NexiusTailer
Copy link
Contributor

NexiusTailer commented Mar 24, 2024

Thanks for implementing most of the suggested stuff! But I'd change just a couple of strings which is printed now, they are:

  1. The 'max_bots' option more or equal how 'max_players' option: "how" -> "than"
  2. Cant create 'scriptfiles' folder: "Cant create" -> "Cannot access"

@Hual
Copy link
Collaborator

Hual commented Mar 29, 2024

I think there should also be warnings for the negative options

@atomlin-git
Copy link
Author

I think there should also be warnings for the negative options

my solution looks unattractive, tell me how to improve it?

image

@Hual
Copy link
Collaborator

Hual commented Mar 31, 2024

I think there should also be warnings for the negative options

my solution looks unattractive, tell me how to improve it?

image

It's fine, no reason to redo it if it's done already

@NexiusTailer
Copy link
Contributor

NexiusTailer commented Mar 31, 2024

I also thought about this warning message:
The 'max_bots' option more or equal than 'max_players' option. Server work can be unpredictable
Basically, the behaviour is predictable, players just can't join in this case. Maybe worth noticing only about "bots option more or equal than players" as the consequences are anyway pretty obvious?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants