Switch to using bitset2. #549
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't make a difference at this stage, but is a precursor to some other changes intended to generally improve memory consumption. Most importantly bitset2 has one very important new function - `find_first`. It isn't quite as efficient as my method was (see Hacker's Delight, ISBN 9780201914658).
Merged
|
OK, Linux apparently has exceptions disabled, while Windows doesn't. |
|
Which is weird, because |
This compiled on Windows because the code wasn't used, but failed on Linux because it was checked anyway.
|
Hopefully fixed that, but as I wrote this as a precursor to some more changes, that aren't really needed since #550 does a good enough job for now, we can leave this for a bit. |
|
Y_Less seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't make a difference at this stage, but is a precursor to some other changes intended to generally improve memory consumption. Most importantly bitset2 has one very important new function -
find_first. It isn't quite as efficient as my method was (see Hacker's Delight, ISBN 9780201914658), but I've forked the original project so we can add internal improvements as we need.