8332448: Make SpaceMangler inherit AllStatic

[albertnetymk]

Extract the state for top out of SpaceMangler. Users (Serial and Parallel GC) already tracks the top before/after GC. The "real" change in this PR are only two places: serialFullGC.cpp and PSParallelCompact::post_compact.

Test: tier1-5

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8332448: Make SpaceMangler inherit AllStatic (Enhancement - P4)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19279/head:pull/19279
$ git checkout pull/19279

Update a local copy of the PR:
$ git checkout pull/19279
$ git pull https://git.openjdk.org/jdk.git pull/19279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19279

View PR using the GUI difftool:
$ git pr show -t 19279

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19279.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332448: Make SpaceMangler inherit AllStatic

Reviewed-by: kbarrett, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• ce99198: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
• f5ab7df: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
• 9f77793: 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
• fb45bab: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
• 6e80512: 8332545: Fix handling of HTML5 entities in Markdown comments

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e1d524cc)
• 00: Full (27c35a9b)

[albertnetymk]

/cc hotspot-gc

[openjdk]

@albertnetymk
The hotspot-gc label was successfully added.

[kimbarrett]

I'd rather the new_top variable declaration was after the comment rather than before.

[kimbarrett]

SpaceMangler::mangle_region should be debug-only rather than not-product, both conceptually, and
because it has no effect in non-debug builds.

[kimbarrett]

Looks good.

[walulyai]

LGTM!

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit 5f2b8d0.
Since your change was applied there have been 6 commits pushed to the master branch:

• 8a49d47: 8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'
• ce99198: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
• f5ab7df: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
• 9f77793: 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
• fb45bab: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
• 6e80512: 8332545: Fix handling of HTML5 entities in Markdown comments

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 5f2b8d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.