Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332403: Anachronistic reference to Netscape Communicator in Swing API docs #19276

Closed
wants to merge 5 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented May 17, 2024

Inadvertent mention of Netscape in Javadoc is removed..


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332403: Anachronistic reference to Netscape Communicator in Swing API docs (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19276/head:pull/19276
$ git checkout pull/19276

Update a local copy of the PR:
$ git checkout pull/19276
$ git pull https://git.openjdk.org/jdk.git pull/19276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19276

View PR using the GUI difftool:
$ git pr show -t 19276

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19276.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332403: Anachronistic reference to Netscape Communicator in Swing API docs

Reviewed-by: abhiscxk, aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 255 new commits pushed to the master branch:

  • 8acdd2d: 8330565: C2: Multiple crashes with CTW after JDK-8316991
  • 0a58cff: 8298405: Implement JEP 467: Markdown Documentation Comments
  • 39a55e9: 8324809: compiler can crash with SOE while proving if two recursive types are disjoint
  • b7ae0ae: 8328572: JFR: Use Class.forPrimitiveName(String)
  • e611151: 8331281: RISC-V: C2: Support vector-scalar and vector-immediate bitwise logic instructions
  • 44bdf99: 8332239: Improve CSS for block tags
  • 9bb6169: 8317621: --add-script should support JavaScript modules
  • 4eb1eaf: 8329617: Update stylesheet for specs and tool documentation
  • d4c2edf: 8331855: Convert jdk.jdeps jdeprscan and jdeps to use the Classfile API
  • beeffd4: 8332109: Convert remaining tests using com.sun.tools.classfile to ClassFile API
  • ... and 245 more: https://git.openjdk.org/jdk/compare/4e5c25ee43d4ec31ed5160fd93a2fd15e35182f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 17, 2024
@mlbridge
Copy link

mlbridge bot commented May 17, 2024

Webrevs

Comment on lines 90 to 91
* keep the selection from changing for some types of edits.
* eg. A table that contains a column of check boxes, the user might
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* keep the selection from changing for some types of edits.
* eg. A table that contains a column of check boxes, the user might
* keep the selection from changing for some types of edits,
* e.g. in a table that contains a column of check boxes, the user might

I think the sentence should be updated a bit, the part that stats with “A table…” is not a new sentence, it shouldn't start with a capital letter, and without the preposition “in a table” the sentence does not look good to me.

Two lines above, “because is most cases” should be changed to “because in most cases”.

* keep the selection from changing for some types of edits.
* eg. A table that contains a column of check boxes, the user might
* keep the selection from changing for some types of edits,
* eg. in a table that contains a column of check boxes, the user might
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most guides recommend to spell “e.g.” with the period after each letter, see an article at Grammarly. Alternatively, it could be replaced with “for example”.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should be "e.g.",

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 17, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 18, 2024

Going to push as commit b92bd67.
Since your change was applied there have been 255 commits pushed to the master branch:

  • 8acdd2d: 8330565: C2: Multiple crashes with CTW after JDK-8316991
  • 0a58cff: 8298405: Implement JEP 467: Markdown Documentation Comments
  • 39a55e9: 8324809: compiler can crash with SOE while proving if two recursive types are disjoint
  • b7ae0ae: 8328572: JFR: Use Class.forPrimitiveName(String)
  • e611151: 8331281: RISC-V: C2: Support vector-scalar and vector-immediate bitwise logic instructions
  • 44bdf99: 8332239: Improve CSS for block tags
  • 9bb6169: 8317621: --add-script should support JavaScript modules
  • 4eb1eaf: 8329617: Update stylesheet for specs and tool documentation
  • d4c2edf: 8331855: Convert jdk.jdeps jdeprscan and jdeps to use the Classfile API
  • beeffd4: 8332109: Convert remaining tests using com.sun.tools.classfile to ClassFile API
  • ... and 245 more: https://git.openjdk.org/jdk/compare/4e5c25ee43d4ec31ed5160fd93a2fd15e35182f8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 18, 2024
@openjdk openjdk bot closed this May 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 18, 2024
@openjdk
Copy link

openjdk bot commented May 18, 2024

@prsadhuk Pushed as commit b92bd67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8332403 branch May 18, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants