-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332403: Anachronistic reference to Netscape Communicator in Swing API docs #19276
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 255 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
* keep the selection from changing for some types of edits. | ||
* eg. A table that contains a column of check boxes, the user might |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* keep the selection from changing for some types of edits. | |
* eg. A table that contains a column of check boxes, the user might | |
* keep the selection from changing for some types of edits, | |
* e.g. in a table that contains a column of check boxes, the user might |
I think the sentence should be updated a bit, the part that stats with “A table…” is not a new sentence, it shouldn't start with a capital letter, and without the preposition “in a table” the sentence does not look good to me.
Two lines above, “because is most cases” should be changed to “because in most cases”.
* keep the selection from changing for some types of edits. | ||
* eg. A table that contains a column of check boxes, the user might | ||
* keep the selection from changing for some types of edits, | ||
* eg. in a table that contains a column of check boxes, the user might |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most guides recommend to spell “e.g.” with the period after each letter, see an article at Grammarly. Alternatively, it could be replaced with “for example”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it should be "e.g.",
/integrate |
Going to push as commit b92bd67.
Your commit was automatically rebased without conflicts. |
Inadvertent mention of Netscape in Javadoc is removed..
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19276/head:pull/19276
$ git checkout pull/19276
Update a local copy of the PR:
$ git checkout pull/19276
$ git pull https://git.openjdk.org/jdk.git pull/19276/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19276
View PR using the GUI difftool:
$ git pr show -t 19276
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19276.diff
Webrev
Link to Webrev Comment