-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API) #19265
Conversation
👋 Welcome back mli! A progress list of the required criteria for merging this PR into |
@Hamlin-Li This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 85 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@Hamlin-Li The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
test/hotspot/jtreg/compiler/vectorization/runner/ArrayShiftOpTest.java
Outdated
Show resolved
Hide resolved
test/hotspot/jtreg/compiler/c2/aarch64/TestVectorShiftShorts.java
Outdated
Show resolved
Hide resolved
test/hotspot/jtreg/compiler/c2/aarch64/TestVectorShiftShorts.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming these tests pass with RVV. Thanks.
Yes, the tests passed. Thanks @RealFYang @luhenry for your reviewing. /integrate |
Going to push as commit 5cf8288.
Your commit was automatically rebased without conflicts. |
@Hamlin-Li Pushed as commit 5cf8288. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Can you help to review this patch?
For vector shift instruct, some corresponding tests are not enabled, this is to enable them.
And the way how vector shift instruct works is not clear, especially both vectorization (SLP in jdk) and Vector API share the same instruct's in riscv_v.ad, so also added some comment to clarify it.
Thanks
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19265/head:pull/19265
$ git checkout pull/19265
Update a local copy of the PR:
$ git checkout pull/19265
$ git pull https://git.openjdk.org/jdk.git pull/19265/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19265
View PR using the GUI difftool:
$ git pr show -t 19265
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19265.diff
Webrev
Link to Webrev Comment