-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328107: Shenandoah/C2: TestVerifyLoopOptimizations test failure #19259
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back roland! A progress list of the required criteria for merging this PR into |
@rwestrel This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 346 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@rwestrel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable, thanks. Passes all the tests I throw at it.
The failure occurs because a load barrier is expanded on the backedge
of the counted loop. That breaks the expected counted loop shape. The
fix I propose is to replace the
CountedLoop
with aLoop
node whenthat happens. We're basically done with optimizations related to
counted loop at this point so this shouldn't make a difference.
/cc hotspot-compiler
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19259/head:pull/19259
$ git checkout pull/19259
Update a local copy of the PR:
$ git checkout pull/19259
$ git pull https://git.openjdk.org/jdk.git pull/19259/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19259
View PR using the GUI difftool:
$ git pr show -t 19259
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19259.diff
Webrev
Link to Webrev Comment