-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic UI: remove max-width for buttons #2388
base: main
Are you sure you want to change the base?
Conversation
The idea was to keep a minimum of place for label and value. |
Your commit of vscode settings is probably unexpected ? |
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
a82ace5
to
12dd98f
Compare
I haven't tested this with various widths of labels.
oops, removed now. |
Using 4.2 M1, I can see that I have to increase the zone for buttons to not have controls for a Player item cut on 2 lines on a phone. And I also see that the buttons in the new settings page are not rendered perfectly on a phone when cut on 2 lines. |
I haven't had a chance to look into this yet, and I'm generally clueless with css. If you have a fix, feel free post it and close this PR. Ideally, the buttons can take up as much horizontal space as possible, especially when there are no labels or the label is short. This way user can set a blank label to maximise the space for the buttons. But when there's a label, then reserve some space for the label. |
I would like to find the proper CSS properties to at least have player controls always on one line when there is enough place for that. |
The solution would probably include changing the css of the labels and/or the container. |
Utilise the wasted space instead of wrapping the buttons into multiple rows
before:
After:
With lots of buttons:
Before:
After: