Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thing and triggerchannel pickers #2129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Thing and triggerchannel pickers #2129

wants to merge 3 commits into from

Conversation

d51x
Copy link
Contributor

@d51x d51x commented Oct 10, 2023

discussion #2128

@d51x
[MainUI] thing-picker: add footer with location and icon into item
3ce2dae 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[MainUI] triggerchannel-picker: add footer with channel description
5080e15 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x d51x requested a review from a team as a code owner October 10, 2023 12:56
@d51x d51x mentioned this pull request Oct 10, 2023
Open
@d51x
[MainUI] triggerchannel-picker: add footer with channel description
6200146 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@relativeci
Copy link

relativeci bot commented Oct 10, 2023

Job #1197: Bundle Size — 15.8MiB (+0.25%).

6200146(current) vs b7270d2 main#1158(baseline)

Warning

Bundle contains 16 duplicate packages – View duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1197		      Baseline
Job #1158
Regression  Initial JS 1.85MiB(+10.94%) 1.67MiB
Regression  Initial CSS 608.95KiB(+0.01%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 2987(+75.71%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1197		      Baseline
Job #1158
Regression  JS 9.28MiB (+0.3%) 9.25MiB
Regression  Other 4.74MiB (+0.24%) 4.73MiB
Regression  CSS 860.19KiB (+0.08%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1197 report View d51x:thing-and-triggerchannel-pi... branch activity

florian-h05
florian-h05 requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, however it does not look good on desktops using the desktop theme:

image

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d51x @florian-h05