Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop openHAB 3.4 support #98

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jul 25, 2023

No description provided.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
SemanticTags.add was only in core for a short time, and not during
any full release

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
@jimtng jimtng added the enhancement New feature or request label Jul 26, 2023
@jimtng
Copy link
Contributor

jimtng commented Jul 26, 2023

Mark this as breaking, to trigger v6.0 ? That way OH3.x people won't auto upgrade to it.

@ccutrer
Copy link
Contributor Author

ccutrer commented Jul 26, 2023

Definitely. I don’t plan on submitting it until we really need to though.

@jimtng jimtng added this to the 6.0.0 milestone Aug 6, 2023
@jimtng jimtng added the breaking Breaking changes that will trigger a major version bump label Aug 7, 2023
@jimtng
Copy link
Contributor

jimtng commented Aug 8, 2023

Recently added @deprecated

  • persistence.rb
  • persistence_spec.rb
  • lib/openhab/rspec/helpers.rb

@jimtng
Copy link
Contributor

jimtng commented Sep 1, 2023

I would vote for proceeding with this sooner rather than later. I'm finding more and more need to add OH version guards.

@jimtng
Copy link
Contributor

jimtng commented Sep 29, 2023

While I think of it, a self reminder that we can include an issue tagged with release summary to have a longer description about a release. See #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes that will trigger a major version bump enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants