Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Unit Hint #2283

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Apr 5, 2024

See openhab/openhab-core#4079

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Copy link

netlify bot commented Apr 5, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 75ce56c
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/6611465d1a79da0008a71318
😎 Deploy Preview https://deploy-preview-2283--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you.

developers/bindings/thing-xml.md Outdated Show resolved Hide resolved
developers/bindings/thing-xml.md Outdated Show resolved Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg requested a review from david-pace April 6, 2024 11:39
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments from my side.

developers/bindings/thing-xml.md Outdated Show resolved Hide resolved
developers/bindings/thing-xml.md Outdated Show resolved Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg requested a review from jlaur April 6, 2024 12:56
@stefan-hoehn
Copy link
Contributor

@jlaur Can you have another look after the changes?

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-hoehn stefan-hoehn added this to the 4.2 milestone May 20, 2024
@stefan-hoehn stefan-hoehn merged commit 29f5334 into openhab:main May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants