Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding UV Index system channel #3878

Merged
merged 5 commits into from
May 20, 2024
Merged

Adding UV Index system channel #3878

merged 5 commits into from
May 20, 2024

Conversation

clinique
Copy link
Contributor

No description provided.

@clinique
Adding UV Index system channel
66d5d72 
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested a review from a team as a code owner November 21, 2023 00:06
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/non-dimensional-discouraged-not-permitted-in-future-versions-of-openhab/151406/5

@lolodomo
Copy link
Contributor

lolodomo commented May 1, 2024

Looks good to me but the build failed. Clicking on "Details" leads to a 404 error. Maybe build should be restarted ?

@J-N-K J-N-K added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels May 1, 2024
@J-N-K J-N-K closed this May 1, 2024
@J-N-K J-N-K reopened this May 1, 2024
@lolodomo
Copy link
Contributor

lolodomo commented May 2, 2024 •
edited

@clinique for information: build failed in integration tests (thing tests).

@clinique
Copy link
Contributor Author

@clinique for information: build failed in integration tests (thing tests).

Am I supposed to do something ?

@J-N-K
Copy link
Member

J-N-K commented May 19, 2024

Yes, fix the test 😀

@clinique
Correcting test
cd07900 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Code review
b2002ed 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Saving all changes
8b8dc2c 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
J-N-K
J-N-K approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@J-N-K
Update bundles/org.openhab.core.thing/src/main/resources/OH-INF/i18n/…
b9e3b9e 
…DefaultSystemChannels.properties

Signed-off-by: J-N-K <github@klug.nrw>
@lolodomo
Copy link
Contributor

Apparently there was a move in 2004 from range 0-10+ to range 1-11+.
https://www.google.com/url?sa=t&source=web&rct=j&opi=89978449&url=https://www.epa.gov/sites/default/files/documents/uviguide.pdf&ved=2ahUKEwijpKGf-ZuGAxXpVaQEHZcEC9YQFnoECA8QAw&usg=AOvVaw0ZeoALcc5SmKDEsOabtvhb
Maybe we should keep minimum at 0.
https://en.wikipedia.org/wiki/Ultraviolet_index

@J-N-K
Copy link
Member

J-N-K commented May 20, 2024

That's twenty years ago. I don't think we need to support that.

@J-N-K J-N-K merged commit 6887db3 into openhab:main May 20, 2024
5 checks passed
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label May 20, 2024
@J-N-K J-N-K added this to the 4.2 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@lolodomo lolodomo lolodomo requested changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clinique @openhab-bot @lolodomo @J-N-K