[boschshc] Support for Smart Water Alarm

[david-pace]

Adds support for Bosch Smart Water Alarm devices.

• add new thing type and new channel types
• add new services for water detector
• refactor CameraNotificationState and PrivacyModeState to a common enum EnabledDisabledState that can be re-used in the water detector tilt service states
• implement handler for new device
• register new device in handler factory and discovery
• add unit tests
• add documentation

closes #16593

[jlaur]

Flawless, many thanks! Will let @GerdZanker have a look before merging.

[david-pace]

Thanks for the review @jlaur ❤️

We should also wait for the confirmation by @name-lake in #16593 whether the sensor-moved channel works. Everything else was already tested with the actual hardware 👍

[GerdZanker]

Nice!

[david-pace]

Hi @mherwege, I have a question about the trigger channel. In the documentation I found that the most suitable system trigger channel type would probably be system.trigger, correct?

I now defined the channel in thing-types.xml like this:

<channel id="sensor-moved" typeId="system.trigger"/>

But I could not find which types of commands I am supposed to send to this channel. Should I send OnOffType.ON commands to trigger, or are there specialized trigger commands for these types of channels?

[mherwege]

I used it extensively in the Elro Connects binding for a similar use. I defined specific channel types for it. The handler has a method triggerChannel to trigger it. Have a look here: https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.binding.elroconnects.

[jlaur]

@david-pace - you can also have a look at #16704 showing an end-to-end implementation of a trigger channel.

[david-pace]

Hi @jlaur and @mherwege, the code is now open for a final review 👍 It was tested with the real hardware by a helpful user in #16593 already ❤️

[jlaur]

Still LGTM :)